Latest update.
This commit is contained in:
@@ -222,6 +222,20 @@ static void x509_sig_info_init(X509_SIG_INFO *siginf, const X509_ALGOR *alg,
|
||||
return;
|
||||
/* Security bits: half number of bits in digest */
|
||||
siginf->secbits = EVP_MD_size(md) * 4;
|
||||
/*
|
||||
* SHA1 and MD5 are known to be broken. Reduce security bits so that
|
||||
* they're no longer accepted at security level 1. The real values don't
|
||||
* really matter as long as they're lower than 80, which is our security
|
||||
* level 1.
|
||||
* https://eprint.iacr.org/2020/014 puts a chosen-prefix attack for SHA1 at
|
||||
* 2^63.4
|
||||
* https://documents.epfl.ch/users/l/le/lenstra/public/papers/lat.pdf
|
||||
* puts a chosen-prefix attack for MD5 at 2^39.
|
||||
*/
|
||||
if (mdnid == NID_sha1)
|
||||
siginf->secbits = 63;
|
||||
else if (mdnid == NID_md5)
|
||||
siginf->secbits = 39;
|
||||
switch (mdnid) {
|
||||
case NID_sha1:
|
||||
case NID_sha256:
|
||||
|
||||
+10
-11
@@ -111,9 +111,9 @@ const char *X509_verify_cert_error_string(long n)
|
||||
case X509_V_ERR_NO_EXPLICIT_POLICY:
|
||||
return "no explicit policy";
|
||||
case X509_V_ERR_DIFFERENT_CRL_SCOPE:
|
||||
return "Different CRL scope";
|
||||
return "different CRL scope";
|
||||
case X509_V_ERR_UNSUPPORTED_EXTENSION_FEATURE:
|
||||
return "Unsupported extension feature";
|
||||
return "unsupported extension feature";
|
||||
case X509_V_ERR_UNNESTED_RESOURCE:
|
||||
return "RFC 3779 resource not subset of parent's resources";
|
||||
case X509_V_ERR_PERMITTED_VIOLATION:
|
||||
@@ -133,7 +133,7 @@ const char *X509_verify_cert_error_string(long n)
|
||||
case X509_V_ERR_CRL_PATH_VALIDATION_ERROR:
|
||||
return "CRL path validation error";
|
||||
case X509_V_ERR_PATH_LOOP:
|
||||
return "Path Loop";
|
||||
return "path loop";
|
||||
case X509_V_ERR_SUITE_B_INVALID_VERSION:
|
||||
return "Suite B: certificate version invalid";
|
||||
case X509_V_ERR_SUITE_B_INVALID_ALGORITHM:
|
||||
@@ -147,13 +147,13 @@ const char *X509_verify_cert_error_string(long n)
|
||||
case X509_V_ERR_SUITE_B_CANNOT_SIGN_P_384_WITH_P_256:
|
||||
return "Suite B: cannot sign P-384 with P-256";
|
||||
case X509_V_ERR_HOSTNAME_MISMATCH:
|
||||
return "Hostname mismatch";
|
||||
return "hostname mismatch";
|
||||
case X509_V_ERR_EMAIL_MISMATCH:
|
||||
return "Email address mismatch";
|
||||
return "email address mismatch";
|
||||
case X509_V_ERR_IP_ADDRESS_MISMATCH:
|
||||
return "IP address mismatch";
|
||||
case X509_V_ERR_DANE_NO_MATCH:
|
||||
return "No matching DANE TLSA records";
|
||||
return "no matching DANE TLSA records";
|
||||
case X509_V_ERR_EE_KEY_TOO_SMALL:
|
||||
return "EE certificate key too weak";
|
||||
case X509_V_ERR_CA_KEY_TOO_SMALL:
|
||||
@@ -161,9 +161,9 @@ const char *X509_verify_cert_error_string(long n)
|
||||
case X509_V_ERR_CA_MD_TOO_WEAK:
|
||||
return "CA signature digest algorithm too weak";
|
||||
case X509_V_ERR_INVALID_CALL:
|
||||
return "Invalid certificate verification context";
|
||||
return "invalid certificate verification context";
|
||||
case X509_V_ERR_STORE_LOOKUP:
|
||||
return "Issuer certificate lookup error";
|
||||
return "issuer certificate lookup error";
|
||||
case X509_V_ERR_NO_VALID_SCTS:
|
||||
return "Certificate Transparency required, but no valid SCTs found";
|
||||
case X509_V_ERR_PROXY_SUBJECT_NAME_VIOLATION:
|
||||
@@ -175,10 +175,9 @@ const char *X509_verify_cert_error_string(long n)
|
||||
case X509_V_ERR_OCSP_CERT_UNKNOWN:
|
||||
return "OCSP unknown cert";
|
||||
case X509_V_ERR_SIGNATURE_ALGORITHM_MISMATCH:
|
||||
return "Subject signature algorithm and issuer public key algorithm mismatch";
|
||||
return "subject signature algorithm and issuer public key algorithm mismatch";
|
||||
case X509_V_ERR_NO_ISSUER_PUBLIC_KEY:
|
||||
return "Issuer certificate doesn't have a public key";
|
||||
|
||||
return "issuer certificate doesn't have a public key";
|
||||
default:
|
||||
/* Printing an error number into a static buffer is not thread-safe */
|
||||
return "unknown certificate verification error";
|
||||
|
||||
+70
-151
@@ -7,6 +7,12 @@
|
||||
* https://www.openssl.org/source/license.html
|
||||
*/
|
||||
|
||||
/*
|
||||
* Low level APIs are deprecated for public use, but still ok for
|
||||
* internal use.
|
||||
*/
|
||||
#include "internal/deprecated.h"
|
||||
|
||||
#include <stdio.h>
|
||||
#include "internal/cryptlib.h"
|
||||
#include <openssl/buffer.h>
|
||||
@@ -14,181 +20,85 @@
|
||||
#include <openssl/evp.h>
|
||||
#include <openssl/x509.h>
|
||||
#include "crypto/x509.h"
|
||||
#include <openssl/ocsp.h>
|
||||
#include <openssl/http.h>
|
||||
#include <openssl/rsa.h>
|
||||
#include <openssl/dsa.h>
|
||||
#include <openssl/x509v3.h>
|
||||
|
||||
#ifndef OPENSSL_NO_SM2
|
||||
|
||||
# include "crypto/asn1.h"
|
||||
# include "crypto/evp.h"
|
||||
|
||||
static int common_verify_sm2(void *data, EVP_PKEY *pkey,
|
||||
int mdnid, int pknid, int req)
|
||||
static void clean_id_ctx(EVP_MD_CTX *ctx)
|
||||
{
|
||||
EVP_PKEY_CTX *pctx = EVP_MD_CTX_pkey_ctx(ctx);
|
||||
|
||||
EVP_PKEY_CTX_free(pctx);
|
||||
EVP_MD_CTX_free(ctx);
|
||||
}
|
||||
|
||||
static EVP_MD_CTX *make_id_ctx(EVP_PKEY *r, ASN1_OCTET_STRING *id)
|
||||
{
|
||||
X509 *x = NULL;
|
||||
X509_REQ *r = NULL;
|
||||
EVP_MD_CTX *ctx = NULL;
|
||||
unsigned char *buf_in = NULL;
|
||||
int ret = -1, inl = 0;
|
||||
size_t inll = 0;
|
||||
EVP_PKEY_CTX *pctx = NULL;
|
||||
const EVP_MD *type = EVP_get_digestbynid(mdnid);
|
||||
ASN1_BIT_STRING *signature = NULL;
|
||||
ASN1_OCTET_STRING *sm2_id = NULL;
|
||||
ASN1_VALUE *tbv = NULL;
|
||||
|
||||
if (type == NULL) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2,
|
||||
ASN1_R_UNKNOWN_MESSAGE_DIGEST_ALGORITHM);
|
||||
goto err;
|
||||
if ((ctx = EVP_MD_CTX_new()) == NULL
|
||||
|| (pctx = EVP_PKEY_CTX_new(r, NULL)) == NULL) {
|
||||
X509err(0, ERR_R_MALLOC_FAILURE);
|
||||
goto error;
|
||||
}
|
||||
|
||||
if (pkey == NULL) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_PASSED_NULL_PARAMETER);
|
||||
return -1;
|
||||
#ifndef OPENSSL_NO_EC
|
||||
if (id != NULL) {
|
||||
if (EVP_PKEY_CTX_set1_id(pctx, id->data, id->length) <= 0) {
|
||||
X509err(0, ERR_R_MALLOC_FAILURE);
|
||||
goto error;
|
||||
}
|
||||
}
|
||||
#endif
|
||||
|
||||
if (req == 1) {
|
||||
r = (X509_REQ *)data;
|
||||
signature = r->signature;
|
||||
sm2_id = r->sm2_id;
|
||||
tbv = (ASN1_VALUE *)&r->req_info;
|
||||
} else {
|
||||
x = (X509 *)data;
|
||||
signature = &x->signature;
|
||||
sm2_id = x->sm2_id;
|
||||
tbv = (ASN1_VALUE *)&x->cert_info;
|
||||
}
|
||||
|
||||
if (signature->type == V_ASN1_BIT_STRING && signature->flags & 0x7) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ASN1_R_INVALID_BIT_STRING_BITS_LEFT);
|
||||
return -1;
|
||||
}
|
||||
|
||||
ctx = EVP_MD_CTX_new();
|
||||
if (ctx == NULL) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_MALLOC_FAILURE);
|
||||
goto err;
|
||||
}
|
||||
|
||||
/* Check public key OID matches public key type */
|
||||
if (EVP_PKEY_type(pknid) != pkey->ameth->pkey_id) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ASN1_R_WRONG_PUBLIC_KEY_TYPE);
|
||||
goto err;
|
||||
}
|
||||
|
||||
if (!EVP_PKEY_set_alias_type(pkey, EVP_PKEY_SM2)) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_EVP_LIB);
|
||||
ret = 0;
|
||||
goto err;
|
||||
}
|
||||
pctx = EVP_PKEY_CTX_new(pkey, NULL);
|
||||
if (pctx == NULL) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_EVP_LIB);
|
||||
ret = 0;
|
||||
goto err;
|
||||
}
|
||||
/* NOTE: we tolerate no actual ID, to provide maximum flexibility */
|
||||
if (sm2_id != NULL
|
||||
&& EVP_PKEY_CTX_set1_id(pctx, sm2_id->data, sm2_id->length) != 1) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_EVP_LIB);
|
||||
ret = 0;
|
||||
goto err;
|
||||
}
|
||||
EVP_MD_CTX_set_pkey_ctx(ctx, pctx);
|
||||
|
||||
if (!EVP_DigestVerifyInit(ctx, NULL, type, NULL, pkey)) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_EVP_LIB);
|
||||
ret = 0;
|
||||
goto err;
|
||||
}
|
||||
|
||||
inl = ASN1_item_i2d(tbv, &buf_in,
|
||||
req == 1 ?
|
||||
ASN1_ITEM_rptr(X509_REQ_INFO) :
|
||||
ASN1_ITEM_rptr(X509_CINF));
|
||||
if (inl <= 0) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_INTERNAL_ERROR);
|
||||
goto err;
|
||||
}
|
||||
if (buf_in == NULL) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_MALLOC_FAILURE);
|
||||
goto err;
|
||||
}
|
||||
inll = inl;
|
||||
|
||||
ret = EVP_DigestVerify(ctx, signature->data,
|
||||
(size_t)signature->length, buf_in, inl);
|
||||
if (ret <= 0) {
|
||||
X509err(X509_F_COMMON_VERIFY_SM2, ERR_R_EVP_LIB);
|
||||
goto err;
|
||||
}
|
||||
ret = 1;
|
||||
err:
|
||||
OPENSSL_clear_free(buf_in, inll);
|
||||
EVP_MD_CTX_free(ctx);
|
||||
return ctx;
|
||||
error:
|
||||
EVP_PKEY_CTX_free(pctx);
|
||||
return ret;
|
||||
EVP_MD_CTX_free(ctx);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
static int x509_verify_sm2(X509 *x, EVP_PKEY *pkey, int mdnid, int pknid)
|
||||
{
|
||||
return common_verify_sm2(x, pkey, mdnid, pknid, 0);
|
||||
}
|
||||
|
||||
static int x509_req_verify_sm2(X509_REQ *x, EVP_PKEY *pkey,
|
||||
int mdnid, int pknid)
|
||||
{
|
||||
return common_verify_sm2(x, pkey, mdnid, pknid, 1);
|
||||
}
|
||||
|
||||
#endif
|
||||
|
||||
int X509_verify(X509 *a, EVP_PKEY *r)
|
||||
{
|
||||
#ifndef OPENSSL_NO_SM2
|
||||
int mdnid, pknid;
|
||||
#endif
|
||||
int rv = 0;
|
||||
EVP_MD_CTX *ctx = NULL;
|
||||
ASN1_OCTET_STRING *id = NULL;
|
||||
|
||||
if (X509_ALGOR_cmp(&a->sig_alg, &a->cert_info.signature))
|
||||
return 0;
|
||||
|
||||
#ifndef OPENSSL_NO_SM2
|
||||
/* Convert signature OID into digest and public key OIDs */
|
||||
if (!OBJ_find_sigid_algs(OBJ_obj2nid(a->sig_alg.algorithm),
|
||||
&mdnid, &pknid)) {
|
||||
X509err(X509_F_X509_VERIFY, ASN1_R_UNKNOWN_SIGNATURE_ALGORITHM);
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (pknid == NID_sm2)
|
||||
return x509_verify_sm2(a, r, mdnid, pknid);
|
||||
id = a->sm2_id;
|
||||
#endif
|
||||
|
||||
return (ASN1_item_verify(ASN1_ITEM_rptr(X509_CINF), &a->sig_alg,
|
||||
&a->signature, &a->cert_info, r));
|
||||
if ((ctx = make_id_ctx(r, id)) != NULL) {
|
||||
rv = ASN1_item_verify_ctx(ASN1_ITEM_rptr(X509_CINF), &a->sig_alg,
|
||||
&a->signature, &a->cert_info, ctx);
|
||||
clean_id_ctx(ctx);
|
||||
}
|
||||
return rv;
|
||||
}
|
||||
|
||||
int X509_REQ_verify(X509_REQ *a, EVP_PKEY *r)
|
||||
{
|
||||
int rv = 0;
|
||||
EVP_MD_CTX *ctx = NULL;
|
||||
ASN1_OCTET_STRING *id = NULL;
|
||||
|
||||
#ifndef OPENSSL_NO_SM2
|
||||
int mdnid, pknid;
|
||||
|
||||
/* Convert signature OID into digest and public key OIDs */
|
||||
if (!OBJ_find_sigid_algs(OBJ_obj2nid(a->sig_alg.algorithm),
|
||||
&mdnid, &pknid)) {
|
||||
X509err(X509_F_X509_REQ_VERIFY, ASN1_R_UNKNOWN_SIGNATURE_ALGORITHM);
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (pknid == NID_sm2)
|
||||
return x509_req_verify_sm2(a, r, mdnid, pknid);
|
||||
id = a->sm2_id;
|
||||
#endif
|
||||
|
||||
return (ASN1_item_verify(ASN1_ITEM_rptr(X509_REQ_INFO),
|
||||
&a->sig_alg, a->signature, &a->req_info, r));
|
||||
if ((ctx = make_id_ctx(r, id)) != NULL) {
|
||||
rv = ASN1_item_verify_ctx(ASN1_ITEM_rptr(X509_REQ_INFO), &a->sig_alg,
|
||||
a->signature, &a->req_info, ctx);
|
||||
clean_id_ctx(ctx);
|
||||
}
|
||||
return rv;
|
||||
}
|
||||
|
||||
int NETSCAPE_SPKI_verify(NETSCAPE_SPKI *a, EVP_PKEY *r)
|
||||
@@ -213,11 +123,21 @@ int X509_sign_ctx(X509 *x, EVP_MD_CTX *ctx)
|
||||
&x->sig_alg, &x->signature, &x->cert_info, ctx);
|
||||
}
|
||||
|
||||
#ifndef OPENSSL_NO_OCSP
|
||||
int X509_http_nbio(OCSP_REQ_CTX *rctx, X509 **pcert)
|
||||
#if !defined(OPENSSL_NO_SOCK)
|
||||
static ASN1_VALUE *simple_get_asn1(const char *url, BIO *bio, BIO *rbio,
|
||||
int timeout, const ASN1_ITEM *it)
|
||||
{
|
||||
return OCSP_REQ_CTX_nbio_d2i(rctx,
|
||||
(ASN1_VALUE **)pcert, ASN1_ITEM_rptr(X509));
|
||||
return OSSL_HTTP_get_asn1(url, NULL, NULL /* no proxy and port */, bio,
|
||||
rbio, NULL /* no callback for SSL/TLS */, NULL,
|
||||
NULL /* headers */, 1024 /* maxline */,
|
||||
0 /* max_resp_len */, timeout,
|
||||
NULL /* expected_content_type */, it);
|
||||
}
|
||||
|
||||
X509 *X509_load_http(const char *url, BIO *bio, BIO *rbio, int timeout)
|
||||
{
|
||||
return (X509 *)simple_get_asn1(url, bio, rbio, timeout,
|
||||
ASN1_ITEM_rptr(X509));
|
||||
}
|
||||
#endif
|
||||
|
||||
@@ -249,12 +169,11 @@ int X509_CRL_sign_ctx(X509_CRL *x, EVP_MD_CTX *ctx)
|
||||
&x->crl, ctx);
|
||||
}
|
||||
|
||||
#ifndef OPENSSL_NO_OCSP
|
||||
int X509_CRL_http_nbio(OCSP_REQ_CTX *rctx, X509_CRL **pcrl)
|
||||
#if !defined(OPENSSL_NO_SOCK)
|
||||
X509_CRL *X509_CRL_load_http(const char *url, BIO *bio, BIO *rbio, int timeout)
|
||||
{
|
||||
return OCSP_REQ_CTX_nbio_d2i(rctx,
|
||||
(ASN1_VALUE **)pcrl,
|
||||
ASN1_ITEM_rptr(X509_CRL));
|
||||
return (X509_CRL *)simple_get_asn1(url, bio, rbio, timeout,
|
||||
ASN1_ITEM_rptr(X509_CRL));
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
+51
-8
@@ -16,6 +16,7 @@
|
||||
#include "crypto/x509.h"
|
||||
#include <openssl/rsa.h>
|
||||
#include <openssl/dsa.h>
|
||||
#include <openssl/serializer.h>
|
||||
|
||||
struct X509_pubkey_st {
|
||||
X509_ALGOR *algor;
|
||||
@@ -66,11 +67,15 @@ int X509_PUBKEY_set(X509_PUBKEY **x, EVP_PKEY *pkey)
|
||||
if (x == NULL)
|
||||
return 0;
|
||||
|
||||
if ((pk = X509_PUBKEY_new()) == NULL)
|
||||
goto error;
|
||||
if (pkey == NULL)
|
||||
goto unsupported;
|
||||
|
||||
if (pkey != NULL && pkey->ameth) {
|
||||
if (pkey->ameth->pub_encode) {
|
||||
if (pkey->ameth != NULL) {
|
||||
if ((pk = X509_PUBKEY_new()) == NULL) {
|
||||
X509err(X509_F_X509_PUBKEY_SET, ERR_R_MALLOC_FAILURE);
|
||||
goto error;
|
||||
}
|
||||
if (pkey->ameth->pub_encode != NULL) {
|
||||
if (!pkey->ameth->pub_encode(pk, pkey)) {
|
||||
X509err(X509_F_X509_PUBKEY_SET,
|
||||
X509_R_PUBLIC_KEY_ENCODE_ERROR);
|
||||
@@ -80,15 +85,53 @@ int X509_PUBKEY_set(X509_PUBKEY **x, EVP_PKEY *pkey)
|
||||
X509err(X509_F_X509_PUBKEY_SET, X509_R_METHOD_NOT_SUPPORTED);
|
||||
goto error;
|
||||
}
|
||||
} else {
|
||||
X509err(X509_F_X509_PUBKEY_SET, X509_R_UNSUPPORTED_ALGORITHM);
|
||||
goto error;
|
||||
} else if (pkey->pkeys[0].keymgmt != NULL) {
|
||||
BIO *bmem = BIO_new(BIO_s_mem());
|
||||
const char *serprop = "format=der,type=public";
|
||||
OSSL_SERIALIZER_CTX *sctx =
|
||||
OSSL_SERIALIZER_CTX_new_by_EVP_PKEY(pkey, serprop);
|
||||
|
||||
if (OSSL_SERIALIZER_to_bio(sctx, bmem)) {
|
||||
const unsigned char *der = NULL;
|
||||
long derlen = BIO_get_mem_data(bmem, (char **)&der);
|
||||
|
||||
pk = d2i_X509_PUBKEY(NULL, &der, derlen);
|
||||
}
|
||||
|
||||
OSSL_SERIALIZER_CTX_free(sctx);
|
||||
BIO_free(bmem);
|
||||
}
|
||||
|
||||
if (pk == NULL)
|
||||
goto unsupported;
|
||||
|
||||
X509_PUBKEY_free(*x);
|
||||
if (!EVP_PKEY_up_ref(pkey)) {
|
||||
X509err(X509_F_X509_PUBKEY_SET, ERR_R_INTERNAL_ERROR);
|
||||
goto error;
|
||||
}
|
||||
*x = pk;
|
||||
|
||||
/*
|
||||
* pk->pkey is NULL when using the legacy routine, but is non-NULL when
|
||||
* going through the serializer, and for all intents and purposes, it's
|
||||
* a perfect copy of |pkey|, just not the same instance. In that case,
|
||||
* we could simply return early, right here.
|
||||
* However, in the interest of being cautious leaning on paranoia, some
|
||||
* application might very well depend on the passed |pkey| being used
|
||||
* and none other, so we spend a few more cycles throwing away the newly
|
||||
* created |pk->pkey| and replace it with |pkey|.
|
||||
* TODO(3.0) Investigate if it's safe to change to simply return here
|
||||
* if |pk->pkey != NULL|.
|
||||
*/
|
||||
if (pk->pkey != NULL)
|
||||
EVP_PKEY_free(pk->pkey);
|
||||
|
||||
pk->pkey = pkey;
|
||||
return EVP_PKEY_up_ref(pkey);
|
||||
return 1;
|
||||
|
||||
unsupported:
|
||||
X509err(X509_F_X509_PUBKEY_SET, X509_R_UNSUPPORTED_ALGORITHM);
|
||||
|
||||
error:
|
||||
X509_PUBKEY_free(pk);
|
||||
|
||||
Reference in New Issue
Block a user