Latest update.
This commit is contained in:
+67
-86
@@ -20,8 +20,14 @@ static EVP_KEYEXCH *evp_keyexch_new(OSSL_PROVIDER *prov)
|
||||
{
|
||||
EVP_KEYEXCH *exchange = OPENSSL_zalloc(sizeof(EVP_KEYEXCH));
|
||||
|
||||
if (exchange == NULL) {
|
||||
ERR_raise(ERR_LIB_EVP, ERR_R_MALLOC_FAILURE);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
exchange->lock = CRYPTO_THREAD_lock_new();
|
||||
if (exchange->lock == NULL) {
|
||||
ERR_raise(ERR_LIB_EVP, ERR_R_MALLOC_FAILURE);
|
||||
OPENSSL_free(exchange);
|
||||
return NULL;
|
||||
}
|
||||
@@ -34,38 +40,17 @@ static EVP_KEYEXCH *evp_keyexch_new(OSSL_PROVIDER *prov)
|
||||
|
||||
static void *evp_keyexch_from_dispatch(int name_id,
|
||||
const OSSL_DISPATCH *fns,
|
||||
OSSL_PROVIDER *prov,
|
||||
void *vkeymgmt_data)
|
||||
OSSL_PROVIDER *prov)
|
||||
{
|
||||
/*
|
||||
* Key exchange cannot work without a key, and key management
|
||||
* from the same provider to manage its keys. We therefore fetch
|
||||
* a key management method using the same algorithm and properties
|
||||
* and pass that down to evp_generic_fetch to be passed on to our
|
||||
* evp_keyexch_from_dispatch, which will attach the key management
|
||||
* method to the newly created key exchange method as long as the
|
||||
* provider matches.
|
||||
*/
|
||||
struct keymgmt_data_st *keymgmt_data = vkeymgmt_data;
|
||||
EVP_KEYMGMT *keymgmt =
|
||||
evp_keymgmt_fetch_by_number(keymgmt_data->ctx, name_id,
|
||||
keymgmt_data->properties);
|
||||
EVP_KEYEXCH *exchange = NULL;
|
||||
int fncnt = 0, paramfncnt = 0;
|
||||
|
||||
if (keymgmt == NULL || EVP_KEYMGMT_provider(keymgmt) != prov) {
|
||||
ERR_raise(ERR_LIB_EVP, EVP_R_NO_KEYMGMT_AVAILABLE);
|
||||
goto err;
|
||||
}
|
||||
|
||||
if ((exchange = evp_keyexch_new(prov)) == NULL) {
|
||||
ERR_raise(ERR_LIB_EVP, ERR_R_MALLOC_FAILURE);
|
||||
goto err;
|
||||
}
|
||||
|
||||
exchange->name_id = name_id;
|
||||
exchange->keymgmt = keymgmt;
|
||||
keymgmt = NULL; /* avoid double free on failure below */
|
||||
|
||||
for (; fns->function_id != 0; fns++) {
|
||||
switch (fns->function_id) {
|
||||
@@ -135,7 +120,6 @@ static void *evp_keyexch_from_dispatch(int name_id,
|
||||
|
||||
err:
|
||||
EVP_KEYEXCH_free(exchange);
|
||||
EVP_KEYMGMT_free(keymgmt);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
@@ -147,7 +131,6 @@ void EVP_KEYEXCH_free(EVP_KEYEXCH *exchange)
|
||||
CRYPTO_DOWN_REF(&exchange->refcnt, &i, exchange->lock);
|
||||
if (i > 0)
|
||||
return;
|
||||
EVP_KEYMGMT_free(exchange->keymgmt);
|
||||
ossl_provider_free(exchange->prov);
|
||||
CRYPTO_THREAD_lock_free(exchange->lock);
|
||||
OPENSSL_free(exchange);
|
||||
@@ -170,71 +153,81 @@ OSSL_PROVIDER *EVP_KEYEXCH_provider(const EVP_KEYEXCH *exchange)
|
||||
EVP_KEYEXCH *EVP_KEYEXCH_fetch(OPENSSL_CTX *ctx, const char *algorithm,
|
||||
const char *properties)
|
||||
{
|
||||
EVP_KEYEXCH *keyexch = NULL;
|
||||
struct keymgmt_data_st keymgmt_data;
|
||||
|
||||
keymgmt_data.ctx = ctx;
|
||||
keymgmt_data.properties = properties;
|
||||
keyexch = evp_generic_fetch(ctx, OSSL_OP_KEYEXCH, algorithm, properties,
|
||||
evp_keyexch_from_dispatch, &keymgmt_data,
|
||||
(int (*)(void *))EVP_KEYEXCH_up_ref,
|
||||
(void (*)(void *))EVP_KEYEXCH_free);
|
||||
|
||||
return keyexch;
|
||||
return evp_generic_fetch(ctx, OSSL_OP_KEYEXCH, algorithm, properties,
|
||||
evp_keyexch_from_dispatch,
|
||||
(int (*)(void *))EVP_KEYEXCH_up_ref,
|
||||
(void (*)(void *))EVP_KEYEXCH_free);
|
||||
}
|
||||
|
||||
int EVP_PKEY_derive_init_ex(EVP_PKEY_CTX *ctx, EVP_KEYEXCH *exchange)
|
||||
int EVP_PKEY_derive_init(EVP_PKEY_CTX *ctx)
|
||||
{
|
||||
int ret;
|
||||
void *provkey = NULL;
|
||||
EVP_KEYEXCH *exchange = NULL;
|
||||
|
||||
if (ctx == NULL) {
|
||||
EVPerr(0, EVP_R_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE);
|
||||
return -2;
|
||||
}
|
||||
|
||||
evp_pkey_ctx_free_old_ops(ctx);
|
||||
ctx->operation = EVP_PKEY_OP_DERIVE;
|
||||
|
||||
if (ctx->engine != NULL)
|
||||
if (ctx->engine != NULL || ctx->keytype == NULL)
|
||||
goto legacy;
|
||||
|
||||
if (exchange != NULL) {
|
||||
if (!EVP_KEYEXCH_up_ref(exchange))
|
||||
goto err;
|
||||
} else {
|
||||
int nid = ctx->pkey != NULL ? ctx->pkey->type : ctx->pmeth->pkey_id;
|
||||
if (ctx->keymgmt == NULL)
|
||||
ctx->keymgmt =
|
||||
EVP_KEYMGMT_fetch(ctx->libctx, ctx->keytype, ctx->propquery);
|
||||
if (ctx->keymgmt != NULL) {
|
||||
const char *supported_exch = NULL;
|
||||
|
||||
if (ctx->keymgmt->query_operation_name != NULL)
|
||||
supported_exch =
|
||||
ctx->keymgmt->query_operation_name(OSSL_OP_KEYEXCH);
|
||||
|
||||
/*
|
||||
* TODO(3.0): Check for legacy handling. Remove this once all all
|
||||
* algorithms are moved to providers.
|
||||
* If we didn't get a supported exch, assume there is one with the
|
||||
* same name as the key type.
|
||||
*/
|
||||
if (ctx->pkey != NULL) {
|
||||
switch (ctx->pkey->type) {
|
||||
case EVP_PKEY_DH:
|
||||
break;
|
||||
default:
|
||||
goto legacy;
|
||||
}
|
||||
exchange = EVP_KEYEXCH_fetch(NULL, OBJ_nid2sn(nid), NULL);
|
||||
} else {
|
||||
goto legacy;
|
||||
}
|
||||
if (supported_exch == NULL)
|
||||
supported_exch = ctx->keytype;
|
||||
|
||||
if (exchange == NULL) {
|
||||
EVPerr(EVP_F_EVP_PKEY_DERIVE_INIT_EX, EVP_R_INITIALIZATION_ERROR);
|
||||
goto err;
|
||||
}
|
||||
/*
|
||||
* Because we cleared out old ops, we shouldn't need to worry about
|
||||
* checking if exchange is already there.
|
||||
*/
|
||||
exchange =
|
||||
EVP_KEYEXCH_fetch(ctx->libctx, supported_exch, ctx->propquery);
|
||||
}
|
||||
|
||||
if (ctx->keymgmt == NULL
|
||||
|| exchange == NULL
|
||||
|| (EVP_KEYMGMT_provider(ctx->keymgmt)
|
||||
!= EVP_KEYEXCH_provider(exchange))) {
|
||||
/*
|
||||
* We don't have the full support we need with provided methods,
|
||||
* let's go see if legacy does. Also, we don't need to free
|
||||
* ctx->keymgmt here, as it's not necessarily tied to this
|
||||
* operation. It will be freed by EVP_PKEY_CTX_free().
|
||||
*/
|
||||
EVP_KEYEXCH_free(exchange);
|
||||
goto legacy;
|
||||
}
|
||||
|
||||
|
||||
ctx->op.kex.exchange = exchange;
|
||||
|
||||
if (ctx->pkey != NULL) {
|
||||
provkey =
|
||||
evp_keymgmt_export_to_provider(ctx->pkey, exchange->keymgmt, 0);
|
||||
if (provkey == NULL) {
|
||||
EVPerr(EVP_F_EVP_PKEY_DERIVE_INIT_EX, EVP_R_INITIALIZATION_ERROR);
|
||||
goto err;
|
||||
}
|
||||
provkey = evp_keymgmt_export_to_provider(ctx->pkey, ctx->keymgmt, 0);
|
||||
/* If export failed, legacy may be able to pick it up */
|
||||
if (provkey == NULL)
|
||||
goto legacy;
|
||||
}
|
||||
ctx->op.kex.exchprovctx = exchange->newctx(ossl_provider_ctx(exchange->prov));
|
||||
if (ctx->op.kex.exchprovctx == NULL) {
|
||||
/* The provider key can stay in the cache */
|
||||
EVPerr(EVP_F_EVP_PKEY_DERIVE_INIT_EX, EVP_R_INITIALIZATION_ERROR);
|
||||
EVPerr(0, EVP_R_INITIALIZATION_ERROR);
|
||||
goto err;
|
||||
}
|
||||
ret = exchange->init(ctx->op.kex.exchprovctx, provkey);
|
||||
@@ -245,9 +238,8 @@ int EVP_PKEY_derive_init_ex(EVP_PKEY_CTX *ctx, EVP_KEYEXCH *exchange)
|
||||
return 0;
|
||||
|
||||
legacy:
|
||||
if (ctx == NULL || ctx->pmeth == NULL || ctx->pmeth->derive == NULL) {
|
||||
EVPerr(EVP_F_EVP_PKEY_DERIVE_INIT_EX,
|
||||
EVP_R_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE);
|
||||
if (ctx->pmeth == NULL || ctx->pmeth->derive == NULL) {
|
||||
EVPerr(0, EVP_R_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE);
|
||||
return -2;
|
||||
}
|
||||
|
||||
@@ -259,11 +251,6 @@ int EVP_PKEY_derive_init_ex(EVP_PKEY_CTX *ctx, EVP_KEYEXCH *exchange)
|
||||
return ret;
|
||||
}
|
||||
|
||||
int EVP_PKEY_derive_init(EVP_PKEY_CTX *ctx)
|
||||
{
|
||||
return EVP_PKEY_derive_init_ex(ctx, NULL);
|
||||
}
|
||||
|
||||
int EVP_PKEY_derive_set_peer(EVP_PKEY_CTX *ctx, EVP_PKEY *peer)
|
||||
{
|
||||
int ret;
|
||||
@@ -284,12 +271,10 @@ int EVP_PKEY_derive_set_peer(EVP_PKEY_CTX *ctx, EVP_PKEY *peer)
|
||||
return -2;
|
||||
}
|
||||
|
||||
provkey =
|
||||
evp_keymgmt_export_to_provider(peer, ctx->op.kex.exchange->keymgmt, 0);
|
||||
if (provkey == NULL) {
|
||||
EVPerr(EVP_F_EVP_PKEY_DERIVE_SET_PEER, ERR_R_INTERNAL_ERROR);
|
||||
return 0;
|
||||
}
|
||||
provkey = evp_keymgmt_export_to_provider(peer, ctx->keymgmt, 0);
|
||||
/* If export failed, legacy may be able to pick it up */
|
||||
if (provkey == NULL)
|
||||
goto legacy;
|
||||
return ctx->op.kex.exchange->set_peer(ctx->op.kex.exchprovctx, provkey);
|
||||
|
||||
legacy:
|
||||
@@ -395,20 +380,16 @@ int EVP_KEYEXCH_number(const EVP_KEYEXCH *keyexch)
|
||||
|
||||
int EVP_KEYEXCH_is_a(const EVP_KEYEXCH *keyexch, const char *name)
|
||||
{
|
||||
return evp_is_a(keyexch->prov, keyexch->name_id, name);
|
||||
return evp_is_a(keyexch->prov, keyexch->name_id, NULL, name);
|
||||
}
|
||||
|
||||
void EVP_KEYEXCH_do_all_provided(OPENSSL_CTX *libctx,
|
||||
void (*fn)(EVP_KEYEXCH *keyexch, void *arg),
|
||||
void *arg)
|
||||
{
|
||||
struct keymgmt_data_st keymgmt_data;
|
||||
|
||||
keymgmt_data.ctx = libctx;
|
||||
keymgmt_data.properties = NULL;
|
||||
evp_generic_do_all(libctx, OSSL_OP_KEYEXCH,
|
||||
(void (*)(void *, void *))fn, arg,
|
||||
evp_keyexch_from_dispatch, &keymgmt_data,
|
||||
evp_keyexch_from_dispatch,
|
||||
(void (*)(void *))EVP_KEYEXCH_free);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user